Support Min connection pool parameter #3009#3438
Support Min connection pool parameter #3009#3438brianc merged 3 commits intobrianc:masterfrom htrajan:support_min_pool_size
Conversation
chasdevs
left a comment
There was a problem hiding this comment.
LGTM; I'm not a maintainer of this library, though 😅
|
nice tests. this looks good to me, tbh! I prefer my pools to drain when my app is idle...feels better to me than leaving a bunch of sockets open doing nothing for > 5 minutes, but I can definitely see in some "needs to be fast, but gets spikey traffic" this could come in handy. That initial connection to the backend is no joke. I've seen it take upwards of a second on GCS in the past. |
Great! What would be the next steps to get this into the next release? |
|
Thoughts on implementing or documenting:
? Keepalives are also sort of related to this, but I think any documentation and work needed there stands on its own. |
I can document that this is not implemented at the moment, and merge this as a first step. Those other things yeah could come in the future. |
|
I will release a new |
|
Hi @brianc, I'm not seeing the update in the latest 8.15.6 release. Do you have an ETA on this? |
|
When create connections with number more than |
|
@htrajan @zyf0330 I'm seeing it right here am I missing something? |
|
@brianc nope, it's all good now. @zyf0330 might have spotted an edge case where my implementation doesn't work. Unfortunately, I'm pretty tied up now and won't have time to look into it in the near future. I was able to deploy the change to my company's application and get the desired outcome of no more |
My attempt to address #3009
Hopefully this is sensible with the tests I've included
I suspect that lack of this functionality is causing my company's app to frequently hit bottlenecks with allocating new db pool connections