Fix SASL to bubble up errors, enable SASL tests in CI, and add informative empty SASL password message#2901
Merged
brianc merged 4 commits intobrianc:masterfrom Jan 23, 2023
Conversation
Owner
|
aww thank you, this is an awesome change! 💃 Will get this merged & pushed out ASAP! |
|
AWESOME! Thank you for your commits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Couple of SASL related commits here:
Number 3 should actually close out #2757. Interestingly this was brought up in 2019 when the SASL code was first added: #1927. This should close that out too.