Conversation
We don't really need a `CommentMap` to find comments. In fact, creating a `CommentMap` is still iterating over all comments in a file to build it. Instead of deferring that and allocating a map, we can just iterate like this ourselves. This will improve performance, especially in the cases where we created a `CommentMap` _before_ we decided if a check was enabled and it wasn't.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't really need a
CommentMapto find comments. In fact, creating aCommentMapis still iterating over all comments in a file to build it. Instead of deferring that and allocating a map, we can just iterate like this ourselves.This will improve performance, especially in the cases where we created a
CommentMapbefore we decided if a check was enabled and it wasn't.This brings the default settings down on the
prometheusrepository from the previous average of ~4.927 (noted in #221) to ~1.852 🎉Closes #224