Remove js-related bindings for non-js wasm builds#4528
Conversation
Test262 conformance changes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4528 +/- ##
==========================================
+ Coverage 47.24% 56.99% +9.75%
==========================================
Files 476 503 +27
Lines 46892 57451 +10559
==========================================
+ Hits 22154 32746 +10592
+ Misses 24738 24705 -33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
It might be good to add a hint with |
|
IMO we shouldn't recommend that backend; it disables all random functionality and some apps would want to implement a custom backend instead. I thought the error message was clear enough, but we could also add a small FAQ to point to the |
|
Yeah or maybe just write something saying that "wasm_js" backend is for JS, otherwise they can look at the getrandom docs |
|
I have tried the fork now and it seems to run (or, at least, not have any imports, because I found out my code can never run embedded since the core library uses DOM APIs) |
Fixes #4526. This does not fix the issue for builds with the `temporal` feature enabled. We need to send a patch to `iana-time-zone` to avoid importing `js-sys` unconditionally, but use a feature instead; right now it is impossible to conditionally add `js-sys` for `iana-time-zone`.
Fixes #4526.
This does not fix the issue for builds with the
temporalfeature enabled. We need to send a patch toiana-time-zoneto avoid importingjs-sysunconditionally, but use a feature instead; right now it is impossible to conditionally addjs-sysforiana-time-zone.