Use .prettierrc.json instead of eslint prettier rule to configure format options#654
Merged
bmish merged 1 commit intoeslint-community:mainfrom Mar 11, 2025
Merged
Conversation
.prettierrc.json instead of eslint prettier rule to configure format options.prettierrc.json instead of eslint prettier rule to configure format options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During #648 I have some clash between Prettier and ESLint:
I'm using an editor with support for both tools, however they have a different behaviour when dealing with quotes:
eslintwas using single quotes due to the inline configuration ofeslint.config.jshttps://github.com/bmish/eslint-doc-generator/blob/f73317020aa916ca7fa29eeed2edb33fcc7858dd/eslint.config.js#L28-L33
prettierwas using the double quotes, which is prettier default due to the empty config in.prettierrc.jsonhttps://github.com/bmish/eslint-doc-generator/blob/f73317020aa916ca7fa29eeed2edb33fcc7858dd/.prettierrc.json#L1
To resolve this inconsistency, I added the
singleQuoteoption to.prettierrc.jsonand removed it fromeslint.config.js.There should be no further issues since the ESLint plugin now reads options directly from Prettier's configuration:
https://github.com/prettier/eslint-plugin-prettier?tab=readme-ov-file#options