Conversation
CascadingRadium
previously approved these changes
Apr 30, 2025
CascadingRadium
left a comment
Member
There was a problem hiding this comment.
fix conflicts and rebase
- Added utility function for point intersects polygon - Added usage of shape indexes wherever possible - Removed some new lines to make things consistent - Added appropriate test cases Note - Polygon intersects point will not consider points on the edges a 100 percent of the time. Results are arbitrary and adding support might be a performance hit. Behaviour is still consistent with the past implementation - Polygon intersects polygon will not consider both vertex and edge intersection Adding this support will be a performance hit. Behaviour is still consistent with past implementation
abhinavdangeti
approved these changes
May 7, 2025
CascadingRadium
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note