Rename Vec2::angle_between to Vec2::angle_to#524
Merged
bitshifter merged 2 commits intomainfrom Jun 8, 2024
Merged
Conversation
This method has a different meaning to Vec3::angle_between, which was inconsistent and confusing.
github-merge-queue Bot
pushed a commit
to bevyengine/bevy
that referenced
this pull request
Nov 10, 2024
# Objective `glam` has opted to rename `Vec2::angle_between` to `Vec2::angle_to` because of the difference in semantics compared to `Vec3::angle_between` and others which return an unsigned angle `[0, PI]` where `Vec2::angle_between` returns a signed angle `[-PI, PI]`. We should follow suit for `Rot2` in 0.15 to avoid further confusion. Links: - bitshifter/glam-rs#514 (comment) - bitshifter/glam-rs#524 ## Migration Guide `Rot2::angle_between` has been deprecated, use `Rot2::angle_to` instead, the semantics of `Rot2::angle_between` will change in the future. --------- Co-authored-by: Joona Aalto <jondolf.dev@gmail.com>
mockersf
pushed a commit
to bevyengine/bevy
that referenced
this pull request
Nov 11, 2024
# Objective `glam` has opted to rename `Vec2::angle_between` to `Vec2::angle_to` because of the difference in semantics compared to `Vec3::angle_between` and others which return an unsigned angle `[0, PI]` where `Vec2::angle_between` returns a signed angle `[-PI, PI]`. We should follow suit for `Rot2` in 0.15 to avoid further confusion. Links: - bitshifter/glam-rs#514 (comment) - bitshifter/glam-rs#524 ## Migration Guide `Rot2::angle_between` has been deprecated, use `Rot2::angle_to` instead, the semantics of `Rot2::angle_between` will change in the future. --------- Co-authored-by: Joona Aalto <jondolf.dev@gmail.com>
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Dec 2, 2024
# Objective `glam` has opted to rename `Vec2::angle_between` to `Vec2::angle_to` because of the difference in semantics compared to `Vec3::angle_between` and others which return an unsigned angle `[0, PI]` where `Vec2::angle_between` returns a signed angle `[-PI, PI]`. We should follow suit for `Rot2` in 0.15 to avoid further confusion. Links: - bitshifter/glam-rs#514 (comment) - bitshifter/glam-rs#524 ## Migration Guide `Rot2::angle_between` has been deprecated, use `Rot2::angle_to` instead, the semantics of `Rot2::angle_between` will change in the future. --------- Co-authored-by: Joona Aalto <jondolf.dev@gmail.com>
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Jan 6, 2025
# Objective `glam` has opted to rename `Vec2::angle_between` to `Vec2::angle_to` because of the difference in semantics compared to `Vec3::angle_between` and others which return an unsigned angle `[0, PI]` where `Vec2::angle_between` returns a signed angle `[-PI, PI]`. We should follow suit for `Rot2` in 0.15 to avoid further confusion. Links: - bitshifter/glam-rs#514 (comment) - bitshifter/glam-rs#524 ## Migration Guide `Rot2::angle_between` has been deprecated, use `Rot2::angle_to` instead, the semantics of `Rot2::angle_between` will change in the future. --------- Co-authored-by: Joona Aalto <jondolf.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method has a different meaning to Vec3::angle_between, which was inconsistent and confusing.