Rework the #[flag_name] feature and re-stabilize as #[bitflags(flag_name)]#487
Merged
Conversation
Member
Author
|
While working on this I've also cleaned up the workaround for #320 which has been fixed for a few years now. I've also re-organized our compile-pass tests just for a bit of housekeeping. |
#[flag_name] feature and re-stabilize as #[bitflags(flag_name)]
Member
Author
|
Since we have a second chance to look at this feature, I've namespaced the attribute as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #486
In #483, we added macro code to recognize and handle a custom
#[flag_name]attribute for setting the name of a flag. This was being expanded under theexpr_safe!macro, which already recurses on each attribute on the expression. Combining the two pushed largerbitflagsinvocations over the default 128 recursion depth limit.This PR pulls the logic for computing the flag name out of the logic for wrapping expressions, so we recurse to the same depth as before.