Fix formatting of multi-bit flags with partial overlap#316
Merged
KodrAus merged 2 commits intobitflags:mainfrom Mar 16, 2023
Merged
Fix formatting of multi-bit flags with partial overlap#316KodrAus merged 2 commits intobitflags:mainfrom
KodrAus merged 2 commits intobitflags:mainfrom
Conversation
Member
Author
|
Ok, it looks like the fix for this was fairly straightfoward: we were using the flags themselves to try mask out any bits that don't correspond to a valid flag, but in this example the extra bits do correspond to part of a flag. So we'd mask them out without printing anything for them. Using the iterator as the source of these bits ensures anything not printed by name will get printed as a hex number. |
|
Thanks for getting this fixed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #315
cc @mxk
I've added a repro for the bug reported here: #310 (comment)
It looks like we'll need to tweak the
iter_namesmethod to make sure we include any remaining bits when they overlap, but don't complete, a multi-bit flag.