Merged
Conversation
KodrAus
approved these changes
Jan 31, 2023
Member
KodrAus
left a comment
There was a problem hiding this comment.
Thanks @fintelia 👍 I think this is something I'd be comfortable doing now. My comment about major version bumps was less about semver compatibility and more about making a reasonable commitment to users who care about the presence of unsafe code in their dependencies. You certainly should expect unsafe code to appear or disappear in patches, but I see #[forbid(unsafe_code)] also as a design guideline to avoid any solutions that require unsafe code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #222. Contrary to what is mentioned there, removing this annotation would not constitute a breaking change requiring a major version bump (at least according to normal Rust conventions). It is merely an assertion that the current patch release contains no unsafe code.
Looking for
#![forbid(unsafe_code)]is more reliable than trying to grep the crate source code for instances of "unsafe", since the latter could hypothetically be concealed by macros and such.