Support ejecting flags types from the bitflags macro#351
Merged
KodrAus merged 28 commits intobitflags:mainfrom May 17, 2023
Merged
Support ejecting flags types from the bitflags macro#351KodrAus merged 28 commits intobitflags:mainfrom
KodrAus merged 28 commits intobitflags:mainfrom
Conversation
Member
Author
|
Since we can't yet replace our |
Member
Author
|
Before merging this, we'll need to introduce a bound that ensures you can't use a custom implementation of |
Member
Author
|
Just need to come up with a 1.56.0 compatible method of asserting a custom |
KodrAus
commented
May 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #348
This PR lets you define your flags type outside of the
bitflags!macro, but still optionally use it to generate constants, methods, and trait impls for your flags types:The
BitFlagstrait that can't be manually implemented has also been deprecated in favour of a semver-compatibleFlagstrait that can be manually implemented. This makes it possible to define flags types without using any macros at all: