chore: speed up build of dev profile by ematipico · Pull Request #8432 · biomejs/biome

ematipico · 2025-12-12T09:44:32Z

Summary

Improve dev build performance: https://doc.rust-lang.org/cargo/guide/build-performance.html#cargo-and-compiler-configuration

Test Plan

Green CI

Docs

Updated contribution guide

changeset-bot · 2025-12-12T09:44:36Z

⚠️ No Changeset found

Latest commit: d5a2887

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-12-12T09:47:27Z

Walkthrough

The pull request refines build configuration and development documentation. Cargo.toml removes previous dependency patch overrides and introduces tailored development profiles: a dev profile with selective debugging symbols and a new debugging profile for comprehensive debugging information. CONTRIBUTING.md receives debugging guidance across multiple sections, explaining how the dev profile handles debug information and how to use the debugging profile when testing. No functional code changes or API alterations are introduced.

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately reflects the main changes: adding Cargo profiles and documentation to optimise dev build performance.
Description check	✅ Passed	The description is related to the changeset, referencing improved dev build performance with a link to Rust documentation and mentioning the contribution guide update.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch chore/add-debugging-profile

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9f1b3b0 and b89b7b6.

📒 Files selected for processing (2)

CONTRIBUTING.md (1 hunks)
Cargo.toml (1 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

Cargo.toml

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Use workspace dependencies in the root Cargo.toml; internal crates should use workspace = true for dependencies and path dependencies for dev-dependencies

Files:

Cargo.toml

**/*.toml

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Use just f (alias for just format) to format TOML files before committing

Files:

Cargo.toml

CONTRIBUTING.md

📄 CodeRabbit inference engine (AGENTS.md)

Review and follow the contribution guidelines defined in CONTRIBUTING.md

Files:

CONTRIBUTING.md

🧠 Learnings (11)

📓 Common learnings

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:05:20.371Z
Learning: Applies to crates/biome_formatter/**/biome_*_formatter/Cargo.toml : Include development dependencies in `Cargo.toml` for formatter tests: `biome_formatter_test`, `biome_<language>_factory`, `biome_<language>_parser`, `biome_parser`, `biome_service`, `countme`, `iai`, `quickcheck`, `quickcheck_macros`, and `tests_macros`

Learnt from: CR
Repo: biomejs/biome PR: 0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-11-28T09:08:10.091Z
Learning: Applies to **/*.rs : Use the `dbg!()` macro for debugging output during testing, and pass the `--show-output` flag to `cargo` to view debug output

📚 Learning: 2025-11-24T18:05:20.371Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:05:20.371Z
Learning: Applies to crates/biome_formatter/**/biome_*_formatter/Cargo.toml : Include development dependencies in `Cargo.toml` for formatter tests: `biome_formatter_test`, `biome_<language>_factory`, `biome_<language>_parser`, `biome_parser`, `biome_service`, `countme`, `iai`, `quickcheck`, `quickcheck_macros`, and `tests_macros`

Applied to files:

Cargo.toml
CONTRIBUTING.md

📚 Learning: 2025-11-28T09:08:10.091Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-11-28T09:08:10.091Z
Learning: Applies to Cargo.toml : Use workspace dependencies in the root Cargo.toml; internal crates should use `workspace = true` for dependencies and path dependencies for dev-dependencies

Applied to files:

Cargo.toml

📚 Learning: 2025-11-28T09:08:10.091Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-11-28T09:08:10.091Z
Learning: Applies to **/*.rs : Use the `dbg!()` macro for debugging output during testing, and pass the `--show-output` flag to `cargo` to view debug output

Applied to files:

Cargo.toml
CONTRIBUTING.md

📚 Learning: 2025-11-24T18:05:27.810Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_js_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:05:27.810Z
Learning: Applies to crates/biome_js_formatter/**/*.rs : Use the `dbg_write!` macro to debug formatter output instead of other logging methods

Applied to files:

Cargo.toml
CONTRIBUTING.md

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Use quick testing via `tests/quick_test.rs` by removing the `#[ignore]` macro and modifying the `SOURCE` variable to rapidly validate rule behavior during development

Applied to files:

Cargo.toml

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/biome_rule_options/src/**/*.rs : Wrap optional rule option fields in `Option<_>` to properly track set vs unset options during configuration merging

Applied to files:

Cargo.toml

📚 Learning: 2025-11-24T18:06:12.048Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_service/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:06:12.048Z
Learning: Debug the WorkspaceWatcher by starting the daemon with cargo run --bin=biome -- start and running commands such as cargo run --bin=biome -- lint --use-server <path>

Applied to files:

CONTRIBUTING.md

📚 Learning: 2025-11-24T18:04:57.309Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_diagnostics/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:04:57.309Z
Learning: Applies to crates/biome_diagnostics/**/*.rs : Use helper types from the biome_diagnostics::v2 module (CodeFrameAdvice, CommandAdvice, DiffAdvice, LogAdvice) or implement the Advices trait yourself for custom advice handling

Applied to files:

CONTRIBUTING.md

📚 Learning: 2025-11-28T09:08:10.091Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-11-28T09:08:10.091Z
Learning: Applies to **/*.rs : Use `cargo t` or `cargo test` to run tests; for a single test, pass the test name after the `test` command

Applied to files:

CONTRIBUTING.md

📚 Learning: 2025-11-24T18:04:57.309Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_diagnostics/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:04:57.309Z
Learning: Applies to crates/biome_diagnostics/**/*.rs : Ensure the type implementing Diagnostic derives Debug

Applied to files:

CONTRIBUTING.md

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)

GitHub Check: Check Dependencies
GitHub Check: End-to-end tests
GitHub Check: Test (depot-windows-2022-16)
GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)
GitHub Check: Lint project (depot-windows-2022)
GitHub Check: Test (depot-ubuntu-24.04-arm-16)
GitHub Check: Documentation
GitHub Check: Test Node.js API
GitHub Check: autofix

🔇 Additional comments (1)

Cargo.toml (1)

274-283: No issue here — [profile.dev.package."*"] applies only to external dependencies, not workspace members. Your workspace crates retain debug = "line-tables-only" from [profile.dev], whilst dependencies get debug = false for faster builds. The configuration is correct as written.

ematipico requested review from a team December 12, 2025 09:44

coderabbitai Bot reviewed Dec 12, 2025

View reviewed changes

Comment thread CONTRIBUTING.md

siketyan approved these changes Dec 12, 2025

View reviewed changes

chore: speed up build of dev profile

d5a2887

ematipico force-pushed the chore/add-debugging-profile branch from b89b7b6 to d5a2887 Compare December 12, 2025 09:48

ematipico merged commit e035b91 into main Dec 12, 2025
12 checks passed

ematipico deleted the chore/add-debugging-profile branch December 12, 2025 10:10

l0ngvh pushed a commit to l0ngvh/biome that referenced this pull request Dec 21, 2025

chore: speed up build of dev profile (biomejs#8432)

2c1d9bd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: speed up build of dev profile#8432

chore: speed up build of dev profile#8432
ematipico merged 1 commit intomainfrom
chore/add-debugging-profile

ematipico commented Dec 12, 2025 •

edited

Loading

Uh oh!

changeset-bot Bot commented Dec 12, 2025 •

edited

Loading

Uh oh!

coderabbitai Bot commented Dec 12, 2025

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

ematipico commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Docs

Uh oh!

changeset-bot Bot commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai Bot commented Dec 12, 2025

Walkthrough

Pre-merge checks and finishing touches

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ematipico commented Dec 12, 2025 •

edited

Loading

changeset-bot Bot commented Dec 12, 2025 •

edited

Loading