fix(lint/noUnusedPrivateClassMembers): improve member usage check#7103
Merged
arendjr merged 4 commits intobiomejs:mainfrom Aug 5, 2025
Merged
fix(lint/noUnusedPrivateClassMembers): improve member usage check#7103arendjr merged 4 commits intobiomejs:mainfrom
arendjr merged 4 commits intobiomejs:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 73d1f50 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
arendjr
approved these changes
Aug 5, 2025
Contributor
arendjr
left a comment
There was a problem hiding this comment.
Thanks! Do you want to add a changeset still?
Comment on lines
+221
to
+222
| /// return this.#val++; // increment expression used as return value | ||
| /// return this.#val = 1; //assignment used as expression |
Contributor
There was a problem hiding this comment.
Suggested change
| /// return this.#val++; // increment expression used as return value | |
| /// return this.#val = 1; //assignment used as expression | |
| /// return this.#val++; // increment expression used as return value | |
| /// return this.#val = 1; // assignment used as expression |
CodSpeed Performance ReportMerging #7103 will not alter performanceComparing Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #6933 and #6994.
When the values of private member assignment expressions, increment expressions, etc. are used, those private members are no longer marked as unused.
Test Plan
Additional test cases have been added.
Docs