Skip to content

fix: typo perfer-for → prefer-for#6947

Merged
dyc3 merged 2 commits intobiomejs:mainfrom
JamBalaya56562:prefer-for
Jul 20, 2025
Merged

fix: typo perfer-for → prefer-for#6947
dyc3 merged 2 commits intobiomejs:mainfrom
JamBalaya56562:prefer-for

Conversation

@JamBalaya56562
Copy link
Copy Markdown
Contributor

@JamBalaya56562 JamBalaya56562 commented Jul 19, 2025

Summary

Fix typo in Solid.js ESLint rule name from “perfer-for” to “prefer-for” and add a corresponding changeset

Bug Fixes:

  • Correct rule key in migrate_eslint_any_rule from “solidjs/perfer-for” to “solidjs/prefer-for”
  • Update lint rule declaration to reference “prefer-for” instead of misspelled “perfer-for”

Chores:

  • Add changeset entry for the ESLint plugin fix

Test Plan

Before After
https://github.com/solidjs-community/eslint-plugin-solid/blob/main/packages/eslint-plugin-solid/docs/perfer-for.md https://github.com/solidjs-community/eslint-plugin-solid/blob/main/packages/eslint-plugin-solid/docs/prefer-for.md

Docs

eslint-plugin-solid

@github-actions github-actions Bot added A-CLI Area: CLI A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Jul 19, 2025
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jul 19, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #6947 will not alter performance

Comparing JamBalaya56562:prefer-for (a105516) with main (734d708)

Summary

✅ 115 untouched benchmarks

dyc3
dyc3 approved these changes Jul 19, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@dyc3 dyc3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Comment thread .changeset/eleven-years-act.md Outdated
@JamBalaya56562 @dyc3
chore: update .changeset/eleven-years-act.md
a105516 
Co-authored-by: Carson McManus <dyc3@users.noreply.github.com>
@dyc3 dyc3 merged commit 4c7ed0f into biomejs:main Jul 20, 2025
29 checks passed
@github-actions github-actions Bot mentioned this pull request Jul 19, 2025
Merged
@JamBalaya56562 JamBalaya56562 deleted the prefer-for branch July 20, 2025 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ematipico ematipico ematipico approved these changes

@dyc3 dyc3 dyc3 approved these changes

Assignees

No one assigned

Labels

A-CLI Area: CLI A-Linter Area: linter L-JavaScript Language: JavaScript and super languages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JamBalaya56562 @ematipico @dyc3