fix(biome-js-analyze): detect json import attribute with trimmed text value instead of plain text value#6618
Merged
arendjr merged 2 commits intobiomejs:mainfrom Jun 29, 2025
Conversation
CodSpeed Performance ReportMerging #6618 will not alter performanceComparing Summary
|
arendjr
approved these changes
Jun 29, 2025
Contributor
arendjr
left a comment
There was a problem hiding this comment.
Thank you, looks good!
Would you like to add a changeset still?
🦋 Changeset detectedLatest commit: 4db140d The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
Oh, I missed that, Thank you! I added a changeset in |
Merged
This was referenced Jun 29, 2025
Contributor
|
Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #6610
When detecting JSON import attributes, we were previously using text(). However, text() includes newlines and other whitespace, leading to issues like #6610. To resolve this, we will now detect JSON import attributes by referring to the trimmed text value instead.
This is my first pull request to biome, so Please feel free to point out anything I might have missed!
Test Plan
I believe added test cases covers that