fix(biome_js_analyze): produce diagnogstics for top-level useless fragment that is in a return statement#6544
Merged
ematipico merged 6 commits intobiomejs:mainfrom Jun 26, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 3792258 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodSpeed Performance ReportMerging #6544 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
Loskir
reviewed
Jun 25, 2025
Comment on lines
+8
to
+10
| const str = "str"; | ||
| // should trigger | ||
| return <>{str}</>; |
Contributor
Contributor
Author
There was a problem hiding this comment.
I put the PR back to draft so I can fix it. I'll let you know when I'm done.
Contributor
Author
There was a problem hiding this comment.
The PR is ready for review. Thanks for pointing out the regressions.
6d16d4a to
3816991
Compare
ematipico
requested changes
Jun 26, 2025
Member
ematipico
left a comment
There was a problem hiding this comment.
A changeset is missing. You can check our contribution guide for creating one
Loskir
approved these changes
Jun 26, 2025
Contributor
Author
@ematipico Thanks! PTAL. It's always a joy to contribute on this codebase. |
ematipico
reviewed
Jun 26, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6530