fix(lint): noUselessFragments should ignore fragments with untrimmed whitespaces#6425
Merged
ematipico merged 1 commit intobiomejs:mainfrom Jun 20, 2025
Merged
fix(lint): noUselessFragments should ignore fragments with untrimmed whitespaces#6425ematipico merged 1 commit intobiomejs:mainfrom
ematipico merged 1 commit intobiomejs:mainfrom
Conversation
CodSpeed Performance ReportMerging #6425 will not alter performanceComparing Summary
|
ematipico
approved these changes
Jun 20, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6391
React trims a "padding" whitespaces inside a element when it contains at least one line break; whitespaces without line breaks will never be trimmed and should be considered as a valid text node.
For example, the following code:
is equivalent to:
There is the same logic in
react/jsx-no-unnecessary-fragment: https://github.com/jsx-eslint/eslint-plugin-react/blob/f2869fd6dc76ceb863c5e2aeea8bf4d392508775/lib/rules/jsx-no-useless-fragment.js#L116-L125Test Plan