fix(lint/complexity/useDateNow): improve error message#6413
Merged
minht11 merged 3 commits intobiomejs:mainfrom Jul 5, 2025
wojtekmaj:use-date-now
Merged
fix(lint/complexity/useDateNow): improve error message#6413minht11 merged 3 commits intobiomejs:mainfrom wojtekmaj:use-date-now
minht11 merged 3 commits intobiomejs:mainfrom
wojtekmaj:use-date-now
Conversation
Previously, you would get an error like ``` Use Date.now() instead of new Date().getTime. ``` which wasn't technically correct. If you followed the error message literally, you'd end up with `Date.now()()` in your code.
CodSpeed Performance ReportMerging #6413 will not alter performanceComparing Summary
|
Co-authored-by: Naoki Ikeguchi <me@s6n.jp>
minht11
approved these changes
Jul 5, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously, you would get an error like
which wasn't technically correct. If you followed the error message literally, you'd end up with
Date.now()()in your code.Test Plan
Updated snapshot tests