test: update snapshots by ematipico · Pull Request #10794 · biomejs/biome

ematipico · 2026-06-29T08:48:17Z

Summary

The update of camino caused snapshots to be stale. This PR updates them.

Test Plan

Green CI

Docs

changeset-bot · 2026-06-29T08:48:21Z

⚠️ No Changeset found

Latest commit: 41446ff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2026-06-29T08:48:25Z

✅ Organic activity

No automation signals detected in the analyzed events.

View full analysis →

_{This is an automated analysis by AgentScan}

coderabbitai · 2026-06-29T09:09:55Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0c6b53a3-cfee-436d-90fd-06af09175072

📥 Commits

Reviewing files that changed from the base of the PR and between 35143ed and 41446ff.

⛔ Files ignored due to path filters (3)

crates/biome_module_graph/tests/snapshots/test_astro_component_imports_snapshot.snap is excluded by !**/*.snap and included by **
crates/biome_module_graph/tests/snapshots/test_svelte_component_imports_snapshot.snap is excluded by !**/*.snap and included by **
crates/biome_module_graph/tests/snapshots/test_vue_component_imports_snapshot.snap is excluded by !**/*.snap and included by **

📒 Files selected for processing (2)

crates/biome_module_graph/Cargo.toml
crates/biome_module_graph/tests/spec_tests.rs

🚧 Files skipped from review as they are similar to previous changes (1)

crates/biome_module_graph/tests/spec_tests.rs

Walkthrough

CliSnapshot.configuration_list now uses BTreeMap<String, String> instead of Vec<(String, String)>, with matching default initialisation, insertion, and emission changes. ModuleGraphSnapshot and its test helper now use BTreeMap<String, String> for snapshot input files, and the related test dependency feature and Astro fixture were updated to match.

Suggested labels

A-Tooling

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title matches the main change: refreshing test snapshots.
Description check	✅ Passed	The description is clearly related to the snapshot refresh caused by the dependency update.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch test/snapshots

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@crates/biome_cli/tests/snap_test.rs`:
- Line 45: The snapshot test’s configuration_list is using config file contents
as the BTreeMap key, which can overwrite duplicate configs and drop entries.
Update the collection logic in snap_test.rs around the configuration_list
population to key by a stable file identifier (for example the file path or
another unique name) while still preserving deterministic ordering, and keep the
existing configuration_list field as the snapshot output target.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 931070c8-9fea-4280-91ef-32025f6f2f37

📥 Commits

Reviewing files that changed from the base of the PR and between dd1429c and 0f65142.

⛔ Files ignored due to path filters (14)

crates/biome_cli/tests/snapshots/main_cases_config_extends/extends_config_ok_from_npm_package.snap is excluded by !**/*.snap and included by **
crates/biome_cli/tests/snapshots/main_cases_config_extends/extends_config_ok_from_npm_package_with_author_field.snap is excluded by !**/*.snap and included by **
crates/biome_cli/tests/snapshots/main_cases_config_extends/extends_config_ok_from_npm_package_with_condition_names.snap is excluded by !**/*.snap and included by **
crates/biome_cli/tests/snapshots/main_cases_config_extends/extends_config_two_levels_deep.snap is excluded by !**/*.snap and included by **
crates/biome_cli/tests/snapshots/main_cases_configuration/uses_project_config_before_user_config.snap is excluded by !**/*.snap and included by **
crates/biome_cli/tests/snapshots/main_cases_migrate_v2/should_migrate_nested_config.snap is excluded by !**/*.snap and included by **
crates/biome_cli/tests/snapshots/main_cases_monorepo/should_fail_for_nested_roots.snap is excluded by !**/*.snap and included by **
crates/biome_cli/tests/snapshots/main_cases_monorepo/should_format_nested_files_differently.snap is excluded by !**/*.snap and included by **
crates/biome_cli/tests/snapshots/main_cases_monorepo/should_ignore_files_in_nested_projects.snap is excluded by !**/*.snap and included by **
crates/biome_cli/tests/snapshots/main_cases_monorepo/should_ignore_nested_configuration_in_ignored_directory.snap is excluded by !**/*.snap and included by **
crates/biome_cli/tests/snapshots/main_cases_monorepo/when_running_from_a_subdirectory_should_extend_from_the_root_config.snap is excluded by !**/*.snap and included by **
crates/biome_cli/tests/snapshots/main_commands_lint/should_apply_root_settings_with_stdin_file_path_and_extended_config.snap is excluded by !**/*.snap and included by **
crates/biome_cli/tests/snapshots/main_commands_lint/should_apply_root_settings_with_stdin_file_path_and_extended_non_root_config.snap is excluded by !**/*.snap and included by **
crates/biome_cli/tests/snapshots/main_commands_migrate/should_migrate_nested_files.snap is excluded by !**/*.snap and included by **

📒 Files selected for processing (1)

crates/biome_cli/tests/snap_test.rs

coderabbitai

🧹 Nitpick comments (1)

crates/biome_module_graph/tests/spec_tests.rs (1)
4024-4029: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Rename files_to_snapshot_vec.

It returns a BTreeMap now, so the *_vec suffix is fibbing a bit. Renaming it to files_to_snapshot_map (or similar) would keep the helper honest and the call sites clearer.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@crates/biome_module_graph/tests/spec_tests.rs` around lines 4024 - 4029,
Rename the helper function files_to_snapshot_vec to reflect that it returns a
BTreeMap rather than a Vec, and update all call sites in spec_tests.rs
accordingly. Keep the new name aligned with the return type, such as
files_to_snapshot_map, and ensure any references to files_to_snapshot_vec in
nearby snapshot setup code are updated to match.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@crates/biome_module_graph/tests/spec_tests.rs`:
- Around line 4024-4029: Rename the helper function files_to_snapshot_vec to
reflect that it returns a BTreeMap rather than a Vec, and update all call sites
in spec_tests.rs accordingly. Keep the new name aligned with the return type,
such as files_to_snapshot_map, and ensure any references to
files_to_snapshot_vec in nearby snapshot setup code are updated to match.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a9d26454-a211-470e-889b-95a7cbfeab6a

📥 Commits

Reviewing files that changed from the base of the PR and between ffb19f7 and 35143ed.

⛔ Files ignored due to path filters (13)

crates/biome_module_graph/tests/snapshots/test_astro_component_imports_snapshot.snap is excluded by !**/*.snap and included by **
crates/biome_module_graph/tests/snapshots/test_export_default_imported_binding.snap is excluded by !**/*.snap and included by **
crates/biome_module_graph/tests/snapshots/test_jsx_imports_css_file.snap is excluded by !**/*.snap and included by **
crates/biome_module_graph/tests/snapshots/test_namespace_reexport_type_inference.snap is excluded by !**/*.snap and included by **
crates/biome_module_graph/tests/snapshots/test_resolve_exports.snap is excluded by !**/*.snap and included by **
crates/biome_module_graph/tests/snapshots/test_resolve_generic_return_value_with_multiple_modules.snap is excluded by !**/*.snap and included by **
crates/biome_module_graph/tests/snapshots/test_resolve_import_as_namespace.snap is excluded by !**/*.snap and included by **
crates/biome_module_graph/tests/snapshots/test_resolve_multiple_reexports.snap is excluded by !**/*.snap and included by **
crates/biome_module_graph/tests/snapshots/test_resolve_nested_function_call_with_namespace_in_return_type.snap is excluded by !**/*.snap and included by **
crates/biome_module_graph/tests/snapshots/test_resolve_promise_from_imported_function_returning_reexported_promise_type.snap is excluded by !**/*.snap and included by **
crates/biome_module_graph/tests/snapshots/test_resolve_single_reexport.snap is excluded by !**/*.snap and included by **
crates/biome_module_graph/tests/snapshots/test_svelte_component_imports_snapshot.snap is excluded by !**/*.snap and included by **
crates/biome_module_graph/tests/snapshots/test_vue_component_imports_snapshot.snap is excluded by !**/*.snap and included by **

📒 Files selected for processing (2)

crates/biome_module_graph/tests/snap/mod.rs
crates/biome_module_graph/tests/spec_tests.rs

codspeed-hq · 2026-06-29T09:53:52Z

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 252 skipped benchmarks¹

_{Comparing test/snapshots (41446ff) with main (376a572)²}

252 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on main (dd1429c) during the generation of this report, so 376a572 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

test: update snapshots

7fc052c

github-actions Bot added the A-CLI Area: CLI label Jun 29, 2026

siketyan approved these changes Jun 29, 2026

View reviewed changes

coderabbitai Bot reviewed Jun 29, 2026

View reviewed changes

Comment thread crates/biome_cli/tests/snap_test.rs

test: order configuration files

ffb19f7

ematipico force-pushed the test/snapshots branch from 0f65142 to ffb19f7 Compare June 29, 2026 09:11

test: module graph

002a072

github-actions Bot added the A-Project Area: project label Jun 29, 2026

test: predicable snapshots

35143ed

coderabbitai Bot reviewed Jun 29, 2026

View reviewed changes

chore: fix tests

41446ff

ematipico merged commit 9adcb1a into main Jun 29, 2026
27 of 28 checks passed

ematipico deleted the test/snapshots branch June 29, 2026 14:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

test: update snapshots#10794

test: update snapshots#10794
ematipico merged 5 commits into
mainfrom
test/snapshots

ematipico commented Jun 29, 2026

Uh oh!

changeset-bot Bot commented Jun 29, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 29, 2026

Uh oh!

coderabbitai Bot commented Jun 29, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Uh oh!

codspeed-hq Bot commented Jun 29, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

ematipico commented Jun 29, 2026

Summary

Test Plan

Docs

Uh oh!

changeset-bot Bot commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions Bot commented Jun 29, 2026

✅ Organic activity

Uh oh!

coderabbitai Bot commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Suggested labels

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

codspeed-hq Bot commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

changeset-bot Bot commented Jun 29, 2026 •

edited

Loading

coderabbitai Bot commented Jun 29, 2026 •

edited

Loading

codspeed-hq Bot commented Jun 29, 2026 •

edited

Loading