Skip to content

chore: remove dead code and update CLI comments#10748

Merged
ematipico merged 2 commits into
biomejs:mainfrom
BangDori:fix/cleanup-review-report-findings
Jun 24, 2026
Merged

chore: remove dead code and update CLI comments#10748
ematipico merged 2 commits into
biomejs:mainfrom
BangDori:fix/cleanup-review-report-findings

Conversation

@BangDori

@BangDori BangDori commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Addresses the DEAD_14 and CMT_1 findings from 🐛 Claude Code Review Report #10708.
  • Removes a no-op block statement from the formatter printer.
  • Updates stale check/lint fix mode comments to reference the current CLI options.
  • Verified the updated fix_file_mode comments against the determine_fix_file_mode call sites where fix_file_mode is set.
  • No changeset is needed because this is an internal cleanup and source comment update with no user-facing behavior change.

Test Plan

  • cargo fmt --all --check
  • cargo test
  • cargo test -p biome_formatter printer::tests

Docs

Not applicable. This only updates internal code comments and removes dead code.

AI assistance was used to help investigate and validate the issue. I reviewed the final code changes and test results myself! Thank you!

@changeset-bot

changeset-bot Bot commented Jun 23, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 509fd3f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

✅ Organic activity

No automation signals detected in the analyzed events.

View full analysis →

This is an automated analysis by AgentScan

@github-actions github-actions Bot added A-CLI Area: CLI A-Formatter Area: formatter labels Jun 23, 2026
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7216e5f9-6fa4-421a-bbe6-c6e81fbb3ff6

📥 Commits

Reviewing files that changed from the base of the PR and between 4396496 and 509fd3f.

📒 Files selected for processing (3)
  • crates/biome_cli/src/commands/check.rs
  • crates/biome_cli/src/commands/lint.rs
  • crates/biome_formatter/src/printer/mod.rs
💤 Files with no reviewable changes (1)
  • crates/biome_formatter/src/printer/mod.rs

Walkthrough

Three minor cleanup changes across two crates. In biome_cli, the doc comments for the fix_file_mode field on both CheckExecution and LintExecution are updated to reference the current CLI flags (--write, --fix, --suppress) instead of the obsolete --apply/--apply-suggested, and a note about --unsafe upgrading the fix mode is added. In biome_formatter, a trailing empty placeholder block inside the Fits::Maybe match arm of FitsMeasurer::fits is removed with no behavioural change.

Suggested labels

A-CLI, A-Formatter

Suggested reviewers

  • ematipico
  • dyc3
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarises the main changes: removing dead code (no-op block) and updating CLI-related documentation comments.
Description check ✅ Passed The description clearly relates to the changeset, explaining the motivation (addressing DEAD_14 and CMT_1 findings), the specific changes made, and testing performed.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codspeed-hq

codspeed-hq Bot commented Jun 23, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 178 untouched benchmarks
⏩ 71 skipped benchmarks1

Comparing BangDori:fix/cleanup-review-report-findings (509fd3f) with main (ffe7d33)2

Open in CodSpeed

Footnotes

  1. 71 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (4396496) during the generation of this report, so ffe7d33 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

ematipico
ematipico approved these changes Jun 24, 2026
View reviewed changes

@ematipico ematipico left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating

@ematipico ematipico merged commit d6d55d0 into biomejs:main Jun 24, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ematipico ematipico ematipico approved these changes

Assignees

No one assigned

Labels

A-CLI Area: CLI A-Formatter Area: formatter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BangDori @ematipico