You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
The PR introduces a borrowed constructor for FileGuard in workspace.rs that sets a close_on_drop flag to false, preventing the RAII guard from closing the underlying workspace file on drop. Building on this, a file_features cache (papaya::HashMap<BiomePath, FeaturesSupported>) is added to CrawlerOptions, exposed via two new CrawlerContext trait methods. Handler::can_handle now populates this cache when a file is accepted, and process_file::execute reads from the cache before falling back to a full workspace query. WorkspaceFile::new also uses the borrowed guard for files that already exist in the workspace. Tests are added across workspace.tests.rs, scanner.tests.rs, and process_file.rs.
The description clearly outlines both optimisations (FileGuard and FeaturesSupported caching), acknowledges AI assistance per guidelines, and explains the test coverage and zero user-facing impact.
Linked Issues check
✅ Passed
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
✅ Passed
Check skipped because no linked issues were found for this pull request.
Title check
✅ Passed
The title accurately captures both optimizations: preventing unnecessary file guard drops and reusing computed feature data, which are the core changes across all modified files.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches🧪 Generate unit tests (beta)
Create PR with unit tests
Commit unit tests in branch perf/optimisations
Comment @coderabbitai help to get the list of available commands and usage tips.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small optimisations written with an AI agent:
WorkspaceGuardif the file exists in the workspace.FeaturesSupportedduring scanning.Test Plan
Added new tests. Green CI.
No changeset since this is just an internal change.
Docs