fix(migrate): preserve trivia in recommended migration (#10734)

BangDori · web-flow · commit 43964961c88c · 2026-06-23T16:40:39.000+02:00
diff --git a/.changeset/sad-signs-brush.md b/.changeset/sad-signs-brush.md
@@ -0,0 +1,5 @@
+---
+"@biomejs/biome": patch
+---
+
+Fixed [#10708](https://github.com/biomejs/biome/issues/10708): `biome migrate` now preserves trivia when migrating the deprecated `recommended` option to `preset`.
diff --git a/crates/biome_cli/tests/snapshots/main_cases_migrate_v2/should_migrate_nested_config.snap b/crates/biome_cli/tests/snapshots/main_cases_migrate_v2/should_migrate_nested_config.snap
@@ -28,7 +28,7 @@ expression: redactor(content)
   i Configuration file can be updated.
   
   - {·"linter":·{·"rules":·{·"recommended":·true·}·}·}
-  + {·"root":·false,"linter":·{·"rules":·{·"preset"·:"none"·}·}·}
+  + {·"root":·false,"linter":·{·"rules":·{·"preset":·"none"·}·}·}
   
 
 ```
@@ -39,7 +39,7 @@ expression: redactor(content)
   i Configuration file can be updated.
   
   - {·"linter":·{·"rules":·{·"recommended":·true·}·}·}
-  + {·"linter":·{·"rules":·{·"preset"·:"none"·}·}·}
+  + {·"linter":·{·"rules":·{·"preset":·"none"·}·}·}
   
 
 ```
@@ -50,7 +50,7 @@ expression: redactor(content)
   i Configuration file can be updated.
   
   - {·"linter":·{·"rules":·{·"recommended":·true·}·}·}
-  + {·"root":·false,"linter":·{·"rules":·{·"preset"·:"none"·}·}·}
+  + {·"root":·false,"linter":·{·"rules":·{·"preset":·"none"·}·}·}
   
 
 ```
diff --git a/crates/biome_migrate/src/analyzers/recommended.rs b/crates/biome_migrate/src/analyzers/recommended.rs
@@ -75,12 +75,12 @@ impl Rule for Recommended {
             json_member_name(
                 json_string_literal("preset")
                     .with_leading_trivia_pieces(name.leading_trivia().pieces())
-                    .with_trailing_trivia_pieces(name.leading_trivia().pieces()),
+                    .with_trailing_trivia_pieces(name.trailing_trivia().pieces()),
             )
             .into(),
             token(T![:])
                 .with_leading_trivia_pieces(node.colon_token().ok()?.leading_trivia().pieces())
-                .with_leading_trivia_pieces(node.colon_token().ok()?.trailing_trivia().pieces()),
+                .with_trailing_trivia_pieces(node.colon_token().ok()?.trailing_trivia().pieces()),
             AnyJsonValue::JsonStringValue(new_value.clone()),
         );
 
diff --git a/crates/biome_migrate/tests/specs/migrations/recommended/trivia.jsonc b/crates/biome_migrate/tests/specs/migrations/recommended/trivia.jsonc
@@ -0,0 +1,8 @@
+{
+  "linter": {
+    "rules": {
+      // keep this comment before the key
+      "recommended" /* keep this comment after the key */: true
+    }
+  }
+}
diff --git a/crates/biome_migrate/tests/specs/migrations/recommended/trivia.jsonc.snap b/crates/biome_migrate/tests/specs/migrations/recommended/trivia.jsonc.snap
@@ -0,0 +1,41 @@
+---
+source: crates/biome_migrate/tests/spec_tests.rs
+expression: trivia.jsonc
+---
+# Input
+```json
+{
+  "linter": {
+    "rules": {
+      // keep this comment before the key
+      "recommended" /* keep this comment after the key */: true
+    }
+  }
+}
+
+```
+
+# Diagnostics
+```
+trivia.jsonc:5:7 migrate  FIXABLE  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  ! The recommended option is deprecated.
+  
+    3 │     "rules": {
+    4 │       // keep this comment before the key
+  > 5 │       "recommended" /* keep this comment after the key */: true
+      │       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+    6 │     }
+    7 │   }
+  
+  i Safe fix: Use the new preset field instead.
+  
+    3 3 │       "rules": {
+    4 4 │         // keep this comment before the key
+    5   │ - ······"recommended"·/*·keep·this·comment·after·the·key·*/:·true
+      5 │ + ······"preset"·/*·keep·this·comment·after·the·key·*/:·"recommended"
+    6 6 │       }
+    7 7 │     }
+  
+
+```

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"@biomejs/biome": patch
 +---
++
 +Fixed [#10708](https://github.com/biomejs/biome/issues/10708): `biome migrate` now preserves trivia when migrating the deprecated `recommended` option to `preset`.