This repository was archived by the owner on Dec 17, 2025. It is now read-only.
Implement trait generics on impl-for#76
Merged
VictorKoenders merged 4 commits intobincode-org:trunkfrom Nov 12, 2023
NightEule5:feature/impl-for-trait-generics
Merged
Implement trait generics on impl-for#76VictorKoenders merged 4 commits intobincode-org:trunkfrom NightEule5:feature/impl-for-trait-generics
VictorKoenders merged 4 commits intobincode-org:trunkfrom
NightEule5:feature/impl-for-trait-generics
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## trunk #76 +/- ##
==========================================
+ Coverage 48.06% 48.42% +0.35%
==========================================
Files 20 20
Lines 2041 2030 -11
==========================================
+ Hits 981 983 +2
+ Misses 1060 1047 -13
☔ View full report in Codecov by Sentry. |
VictorKoenders
suggested changes
Nov 11, 2023
Contributor
VictorKoenders
left a comment
There was a problem hiding this comment.
One minor nitpick, looks good otherwise
VictorKoenders
approved these changes
Nov 12, 2023
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #70