Add const support to inherent impl and attr support generally#53
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## trunk #53 +/- ##
==========================================
- Coverage 50.07% 48.46% -1.62%
==========================================
Files 19 19
Lines 1945 2018 +73
==========================================
+ Hits 974 978 +4
- Misses 971 1040 +69
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
@VictorKoenders is this change something you're interested in? |
|
Yes I think this looks good. I think currently virtue does not have a good way to test changes like this, so I need to think about how we're going to test new features in PRs like this. I'll think about this testing framework for a while and get back to this PR when I figure something out. So it'll be a bit before I merge this, sorry! |
|
No good solution has popped up yet and I don't want this to be blocked for too long, so I'll merge this. Thanks! |
I think this resolves #33, but I have not tested any of this code.