This repository was archived by the owner on Dec 17, 2025. It is now read-only.
feat: make ConstGeneric fields public#50
Merged
VictorKoenders merged 2 commits intobincode-org:trunkfrom Apr 1, 2023
Merged
Conversation
Also make `ident` function public, but as a `&` instead of a clone.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## trunk #50 +/- ##
=======================================
Coverage 49.13% 49.13%
=======================================
Files 19 19
Lines 1911 1911
=======================================
Hits 939 939
Misses 972 972
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
VictorKoenders
suggested changes
Apr 1, 2023
Contributor
VictorKoenders
left a comment
There was a problem hiding this comment.
One minor thing, otherwise LGTM
VictorKoenders
approved these changes
Apr 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also make
identfunction public, but as a&instead of a clone.