This repository was archived by the owner on Dec 17, 2025. It is now read-only.
Allow adding generics to impl and trait name#90
Merged
VictorKoenders merged 4 commits intobincode-org:trunkfrom Nov 8, 2024
Merged
Allow adding generics to impl and trait name#90VictorKoenders merged 4 commits intobincode-org:trunkfrom
impl and trait name#90VictorKoenders merged 4 commits intobincode-org:trunkfrom
Conversation
branchseer
commented
Nov 6, 2024
src/parse/body.rs
Outdated
| /// - `Baz = 5` | ||
| /// - `Baz(i32) = 5` | ||
| /// - `Baz { a: i32} = 5` | ||
| /// |
Contributor
Author
There was a problem hiding this comment.
Fix error raised by rust-clippy 0.1.81:
error: doc list item without indentation
--> src/parse/body.rs:367:9
|
367 | /// In either case this value will be `Some(Literal::i32(5))`
| ^
|
Contributor
|
One minor formatting issue: Diff in /home/runner/work/virtue/virtue/src/parse/body.rs:364:
/// - `Baz = 5`
/// - `Baz(i32) = 5`
/// - `Baz { a: i32} = 5`
- ///
+ ///
/// In either case this value will be `Some(Literal::i32(5))`
pub value: Option<Literal>,
/// The attributes of this variantOther than that LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites of bincode-org/bincode#710.
This PR allows
impl<'a> Foo<&'a str> for StructOrEnum<'a>implkeyword:impl<T1, T2, Bar> Foo for StructOrEnum<T1, T2>