Skip to content
This repository was archived by the owner on Aug 15, 2025. It is now read-only.

2.0.0 stable#742

Merged
3 commits merged intotrunkfrom
release/2.0.0-stable
Mar 6, 2025
Merged

2.0.0 stable#742
3 commits merged intotrunkfrom
release/2.0.0-stable

Conversation

@VictorKoenders
Copy link
Contributor

@VictorKoenders VictorKoenders commented Jan 30, 2025

No description provided.

@VictorKoenders VictorKoenders mentioned this pull request Feb 5, 2025
Closed
Havunen
Havunen reviewed Feb 16, 2025
View reviewed changes
derive/Cargo.toml
"Zoey Riordan <zoey@dos.cafe>",
"Victor Koenders <bincode@trangar.com>",
]
edition = "2021"
Copy link

@Havunen Havunen Feb 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust 1.85 brings support for Edition2024, maybe that could be updated as well?

Copy link
Contributor Author

@VictorKoenders VictorKoenders Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We currently don't see the point of upgrading to 2024, as the rust compiler will still be able to run 2021 code. We do have the option to bump to 2024 later if we want to start adding new 2024 features

@lherman-cs
Copy link

lherman-cs commented Feb 23, 2025

@VictorKoenders 2024 edition has become stable, rust-lang/rust#133349. What can we do to help releasing bincode 2.0.0?

@VictorKoenders
Copy link
Contributor Author

VictorKoenders commented Mar 2, 2025

Start by banning 40 hour work weeks, they're exhausting

@VictorKoenders VictorKoenders force-pushed the release/2.0.0-stable branch 2 times, most recently from 2b3fac5 to 0cf3624 Compare March 2, 2025 16:28
@VictorKoenders
Copy link
Contributor Author

VictorKoenders commented Mar 2, 2025

Would be really nice if we can merge #710 before releasing 2.0

@ghost
Copy link

ghost commented Mar 3, 2025

The readme's MSRV section should be updated to reflect the selected MSRV. Additionally, it should have a sentence mentioning that some features (e.g. serde) will change MSRV guarantees. I suggest adding a column in the lib.rs feature table documenting if a feature is MSRV affecting or not

@ghost ghost marked this pull request as ready for review March 6, 2025 16:49
@ghost ghost merged commit a338109 into trunk Mar 6, 2025
100 of 101 checks passed
@ghost ghost deleted the release/2.0.0-stable branch August 15, 2025 11:01
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@Havunen Havunen Havunen left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@VictorKoenders @lherman-cs @Havunen