This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Implement basic traits for Compat and BorrowCompat#734
Merged
VictorKoenders merged 1 commit intobincode-org:trunkfrom Dec 6, 2024
Merged
Implement basic traits for Compat and BorrowCompat#734VictorKoenders merged 1 commit intobincode-org:trunkfrom
Compat and BorrowCompat#734VictorKoenders merged 1 commit intobincode-org:trunkfrom
Conversation
Contributor
|
Makes a lot of sense, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrapper types
CompatandBorrowCompatdo not introduce any kind of complexity or usage context to the inner type, and their only purpose is to provide an implementation forbincodetraits.So, it would be nice to make them as flexible as possible by deriving all common traits:
#[derive(Clone, PartialEq, Eq, PartialOrd, Ord, Hash, Default)]