This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Implement Encode & Decode for Wrapping<T> types#686
Merged
VictorKoenders merged 2 commits intobincode-org:trunkfrom Dec 15, 2023
Merged
Implement Encode & Decode for Wrapping<T> types#686VictorKoenders merged 2 commits intobincode-org:trunkfrom
VictorKoenders merged 2 commits intobincode-org:trunkfrom
Conversation
Contributor
|
I double checked serde's implementation (which matches your implementation, so you're good) and I noticed they also implement |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## trunk #686 +/- ##
==========================================
+ Coverage 57.24% 57.39% +0.15%
==========================================
Files 51 51
Lines 4350 4366 +16
==========================================
+ Hits 2490 2506 +16
Misses 1860 1860 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
I don't mind at all :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Structures can clearly indicate that the value may overflow and it is intended behaviour