Use const functions where possible#684
Conversation
|
Looks good to me. Out of pure interest, can you check if this actually improves any of the benchmarks? |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## trunk #684 +/- ##
=======================================
Coverage 57.24% 57.24%
=======================================
Files 51 51
Lines 4350 4350
=======================================
Hits 2490 2490
Misses 1860 1860 ☔ View full report in Codecov by Sentry. |
I'm not quite sure I understand what you're asking. You should also be aware that removing |
I just used clippy for this. I actually assume that you will not want the brunt of this change but I figured it was easier to make the change everywhere then simply pick the ones you deem acceptable (if any).
I definitey think some of the constructors should be
const.Thanks in advance!