Skip to content
This repository was archived by the owner on Aug 15, 2025. It is now read-only.

Fix inconsistent naming between serde and non-serde functions#671

Merged
VictorKoenders merged 2 commits intotrunkfrom
fix-serde-naming
Oct 15, 2023
Merged

Fix inconsistent naming between serde and non-serde functions#671
VictorKoenders merged 2 commits intotrunkfrom
fix-serde-naming

Conversation

@VictorKoenders
Copy link
Contributor

Fixes #654

@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (08556ca) 56.85% compared to head (e7db579) 56.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk     #671      +/-   ##
==========================================
+ Coverage   56.85%   56.90%   +0.04%     
==========================================
  Files          51       51              
  Lines        4306     4304       -2     
==========================================
+ Hits         2448     2449       +1     
+ Misses       1858     1855       -3     
Files Coverage Δ
src/error.rs 0.00% <ø> (ø)
src/features/serde/de_owned.rs 76.61% <100.00%> (ø)
src/features/serde/mod.rs 30.43% <ø> (ø)
src/lib.rs 16.81% <ø> (+0.03%) ⬆️
tests/serde.rs 98.18% <100.00%> (+0.03%) ⬆️
src/features/impl_alloc.rs 62.05% <50.00%> (+0.12%) ⬆️
src/features/serde/de_borrowed.rs 21.35% <85.71%> (+0.74%) ⬆️
src/features/serde/ser.rs 76.72% <80.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VictorKoenders VictorKoenders merged commit 4977966 into trunk Oct 15, 2023
@VictorKoenders VictorKoenders deleted the fix-serde-naming branch October 15, 2023 13:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bincode v2, serde functions do not match naming and arguments of bincode functions

1 participant