This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Compat and BorrowCompat Debug and Display implementations#670
Merged
VictorKoenders merged 4 commits intobincode-org:trunkfrom Oct 21, 2023
Merged
Compat and BorrowCompat Debug and Display implementations#670VictorKoenders merged 4 commits intobincode-org:trunkfrom
VictorKoenders merged 4 commits intobincode-org:trunkfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #670 +/- ##
==========================================
+ Coverage 56.90% 57.30% +0.40%
==========================================
Files 51 51
Lines 4304 4335 +31
==========================================
+ Hits 2449 2484 +35
+ Misses 1855 1851 -4
☔ View full report in Codecov by Sentry. |
VictorKoenders
suggested changes
Oct 15, 2023
Contributor
Author
|
@VictorKoenders thanks for your review, I have fixed the things you have pointed out. Let me know if anything else may be done. |
VictorKoenders
approved these changes
Oct 21, 2023
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #648. This is my first PR in this project so I am sorry for something does not respect the contribution standards. Please let me know if something has to be changed.