Skip to content
This repository was archived by the owner on Aug 15, 2025. It is now read-only.

Allow generics in impl_borrow_decode#635

Merged
VictorKoenders merged 7 commits intobincode-org:trunkfrom
dullbananas:dullbananas-patch-1
Jun 19, 2023
Merged

Allow generics in impl_borrow_decode#635
VictorKoenders merged 7 commits intobincode-org:trunkfrom
dullbananas:dullbananas-patch-1

Conversation

@dullbananas
Copy link
Contributor

No description provided.

@VictorKoenders
Copy link
Contributor

VictorKoenders commented May 14, 2023

Thanks! Could you add some tests for this as well?

I think adding this implementation for some of the std types, I'm thinking of Vec, HashMap, etc, would also suffice as a test case

@codecov
Copy link

codecov bot commented May 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.50 🎉

Comparison is base (7bc7c89) 54.90% compared to head (5469727) 55.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk     #635      +/-   ##
==========================================
+ Coverage   54.90%   55.40%   +0.50%     
==========================================
  Files          51       51              
  Lines        4459     4400      -59     
==========================================
- Hits         2448     2438      -10     
+ Misses       2011     1962      -49     
Impacted Files Coverage Δ
src/de/impls.rs 63.71% <ø> (+0.35%) ⬆️
src/de/mod.rs 24.17% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dullbananas
Copy link
Contributor Author

Done

auto-merge was automatically disabled June 17, 2023 03:56

Head branch was pushed to by a user without write access

@VictorKoenders VictorKoenders merged commit 224e412 into bincode-org:trunk Jun 19, 2023
@VictorKoenders
Copy link
Contributor

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants