This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Add DecodeError::Other#602
Merged
VictorKoenders merged 1 commit intobincode-org:trunkfrom Nov 21, 2022
odysa:feat/error
Merged
Conversation
Codecov ReportBase: 54.19% // Head: 54.19% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## trunk #602 +/- ##
=======================================
Coverage 54.19% 54.19%
=======================================
Files 50 50
Lines 4410 4406 -4
=======================================
- Hits 2390 2388 -2
+ Misses 2020 2018 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an
EncodeError::Other(&'static str)inbincode/src/error.rs
Lines 18 to 19 in ba4d196
but not in
DecodeError.I think adding
Other(&'static str)toDecodeErrormakes errors more user-friendly.