Implement Encode for tuples with up-to 16 elements.#583
Implement Encode for tuples with up-to 16 elements.#583VictorKoenders merged 1 commit intobincode-org:trunkfrom
Conversation
This makes it match the implementation for Decode which is already supports up to 16 fields. Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
Codecov ReportBase: 55.66% // Head: 54.21% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## trunk #583 +/- ##
==========================================
- Coverage 55.66% 54.21% -1.46%
==========================================
Files 50 50
Lines 4313 4429 +116
==========================================
Hits 2401 2401
- Misses 1912 2028 +116
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
I forget why this isn't a macro as well, but I see no reason to block this PR on that |
|
For your vmware PR; the next release candidate milestone is tracked here: https://github.com/bincode-org/bincode/milestone/6 |
I tried to improve that, but struggled with generating code that uses .0, .1, .2 etc. when trying to access the tuple members A, B, C etc. for calling encode. So eventually I gave up. For future reference: Maybe the right way is to unpack the tuple with something like |
This makes it match the implementation of Decode which already supports up to 16 fields.