This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Add impls for Rc<[T]> and Arc<[T]>#552
Merged
VictorKoenders merged 1 commit intobincode-org:trunkfrom Jun 15, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #552 +/- ##
==========================================
- Coverage 54.47% 54.44% -0.03%
==========================================
Files 49 49
Lines 4417 4423 +6
==========================================
+ Hits 2406 2408 +2
- Misses 2011 2015 +4
Continue to review full report at Codecov.
|
Contributor
Author
|
@VictorKoenders thank you! With this change I managed to successfully port all my code to bincode 2.0. I use bincode extensively for networking and a custom file format, and everything seems to work well and is backwards compatible with 1.x. I'm okay with having git dependencies and I'm in no rush, but would appreciate 2.0.0-rc.2 at some point :) Edit: as a bonus, without |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #551.