This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #538 +/- ##
=======================================
Coverage 54.89% 54.89%
=======================================
Files 47 47
Lines 4201 4201
=======================================
Hits 2306 2306
Misses 1895 1895
Continue to review full report at Codecov.
|
Cargo.toml
Outdated
| [dependencies] | ||
| bincode_derive = { path = "derive", version = "2.0.0-rc.1", optional = true } | ||
| serde_incl = { package = "serde", version = "1.0", default-features = false, optional = true } | ||
| serde = { package = "serde", version = "1.0", default-features = false, optional = true } |
There was a problem hiding this comment.
This doesn't need the package = "serde" anymore, I think
ghost
reviewed
May 21, 2022
ghost
left a comment
There was a problem hiding this comment.
Fix the one comment left by someone else please. :)
ghost
approved these changes
May 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust 1.60 now has weak dependencies, meaning we don't have to do our serde hack any more.
Closes #472