This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Allow encoding/decoding of HashMap and HashSet with custom hash algorithms#529
Merged
VictorKoenders merged 1 commit intobincode-org:trunkfrom Mar 28, 2022
Merged
Allow encoding/decoding of HashMap and HashSet with custom hash algorithms#529VictorKoenders merged 1 commit intobincode-org:trunkfrom
VictorKoenders merged 1 commit intobincode-org:trunkfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #529 +/- ##
==========================================
+ Coverage 71.02% 71.16% +0.14%
==========================================
Files 47 47
Lines 3182 3198 +16
==========================================
+ Hits 2260 2276 +16
Misses 922 922
Continue to review full report at Codecov.
|
VictorKoenders
approved these changes
Mar 28, 2022
Contributor
VictorKoenders
left a comment
There was a problem hiding this comment.
Looks good to me, thanks! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementations of Encode and Decode for HashMap and HashSet are only defined for the default hash algorithm. However, these types also allow a custom hash type to be defined. At present, maps and sets using custom hashers cannot be handled by bincode.
This pull request adds the necessary functionality to support custom hash algorithms. The main change is the use of
with_capacity_and_hasherinstead ofwith_capacitywhen creating the new object in the Decode implementation.The pull request also adds test cases in
tests/std.rsto ensure that both HashMap and HashSet with custom hash algorithms can be handled successfully.