This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Add zoxide under Bincode in the Wild#525
Merged
VictorKoenders merged 1 commit intobincode-org:trunkfrom Mar 15, 2022
ajeetdsouza:patch-1
Merged
Add zoxide under Bincode in the Wild#525VictorKoenders merged 1 commit intobincode-org:trunkfrom ajeetdsouza:patch-1
VictorKoenders merged 1 commit intobincode-org:trunkfrom
ajeetdsouza:patch-1
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #525 +/- ##
=======================================
Coverage 71.08% 71.08%
=======================================
Files 47 47
Lines 3178 3178
=======================================
Hits 2259 2259
Misses 919 919 Continue to review full report at Codecov.
|
VictorKoenders
approved these changes
Mar 15, 2022
Contributor
VictorKoenders
left a comment
There was a problem hiding this comment.
LGTM
I tried porting zoxide to bincode 2.0.0-rc, but I ran into some issues with the #[serde(borrow)] flag you use for Vec<Dir>. This will require some internal rewrites, but expect a PR on that soon.
Thanks for letting us know!
Contributor
Author
|
That sounds great, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, zoxide seems to be a different use of Bincode from the ones mentioned in the README, so I thought you might like to include it here.
Since it's a shell plugin, I decided to optimize for performance as much as possible. zoxide has to store a rather small database, so Bincode becomes a really good choice -- at that size, it's significantly faster than SQLite as well as a couple of other binary formats I tested against.