This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Reference implementations for Reader and Writer#507
Merged
VictorKoenders merged 1 commit intobincode-org:trunkfrom Feb 23, 2022
Merged
Reference implementations for Reader and Writer#507VictorKoenders merged 1 commit intobincode-org:trunkfrom
VictorKoenders merged 1 commit intobincode-org:trunkfrom
Conversation
…mes from Reader's one
Codecov Report
@@ Coverage Diff @@
## trunk #507 +/- ##
==========================================
- Coverage 70.86% 70.77% -0.09%
==========================================
Files 47 47
Lines 3165 3169 +4
==========================================
Hits 2243 2243
- Misses 922 926 +4
Continue to review full report at Codecov.
|
VictorKoenders
approved these changes
Feb 23, 2022
Contributor
VictorKoenders
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a
Writerimplementation for&mut T: Writer, as there's one for Reader already.I also removed unnecessary lifetime generics from the reference implementation for Reader since they are not needed.