This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Merged
Conversation
VictorKoenders
suggested changes
Feb 6, 2022
Contributor
|
Found some compatibility problems, see #503 for more info |
2963a64 to
b8595e0
Compare
8fd5b45 to
af3415a
Compare
Contributor
Author
|
I am a disaster to rebase with merged branches. |
23a7c0e to
8fd5b45
Compare
VictorKoenders
approved these changes
Feb 7, 2022
Codecov Report
@@ Coverage Diff @@
## trunk #500 +/- ##
==========================================
+ Coverage 70.72% 70.86% +0.14%
==========================================
Files 46 47 +1
Lines 3149 3165 +16
==========================================
+ Hits 2227 2243 +16
Misses 922 922
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HI, as requested, I implemented the test required for crash that I am experiencing in my application.
Here is the demo for the crash in my application:
https://github.com/ppamorim/openraft/tree/bincode-bug/example-raft-kv
You will need to run
./test-cluster.sh, wait it to finish and read the logn1.log. The code that causes the crash is here: https://github.com/ppamorim/openraft/blob/bincode-bug/example-raft-kv/src/store/mod.rs#L230-L244The struct that causes the problem is here: https://github.com/datafuselabs/openraft/blob/main/openraft/src/membership/membership.rs#L21