This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Fixed an error in bincode derive where it would implement the wrong trait if a generic parameter is present#487
Merged
VictorKoenders merged 5 commits intotrunkfrom Jan 23, 2022
Merged
Conversation
…rait if a generic parameter is present
Codecov Report
@@ Coverage Diff @@
## trunk #487 +/- ##
==========================================
+ Coverage 68.73% 69.26% +0.53%
==========================================
Files 39 39
Lines 2875 2925 +50
==========================================
+ Hits 1976 2026 +50
Misses 899 899
Continue to review full report at Codecov.
|
ghost
approved these changes
Jan 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For any enum with generic argument
T, bincode-derive would implement a code like: