This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Merged
Conversation
1093a93 to
a4365a1
Compare
ghost
reviewed
Jan 18, 2022
Codecov Report
@@ Coverage Diff @@
## trunk #477 +/- ##
==========================================
- Coverage 66.44% 66.17% -0.28%
==========================================
Files 38 38
Lines 2691 2702 +11
==========================================
Hits 1788 1788
- Misses 903 914 +11
Continue to review full report at Codecov.
|
ghost
approved these changes
Jan 19, 2022
5ddd0e3 to
89b482b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be merged after #475
This PR improves
serdesupport forallocandno_stdtargets. Until #472 is stabilized, we'll have to make do with this.I also took the liberty to move all of serde's errors to
EncodeError::SerdeandDecodeError::Serde, so they don't pollute the main error too much.