Skip to content
This repository was archived by the owner on Aug 15, 2025. It is now read-only.

Switched Decode and BorrowDecode to take &mut D#470

Merged
VictorKoenders merged 2 commits intotrunkfrom
mut_ref_decode
Jan 11, 2022
Merged

Switched Decode and BorrowDecode to take &mut D#470
VictorKoenders merged 2 commits intotrunkfrom
mut_ref_decode

Conversation

@VictorKoenders
Copy link
Contributor

fixes #467

@VictorKoenders VictorKoenders requested a review from a user January 10, 2022 18:31
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2022

Codecov Report

Merging #470 (c4cb2d7) into trunk (6d38649) will decrease coverage by 0.09%.
The diff coverage is 89.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk     #470      +/-   ##
==========================================
- Coverage   67.01%   66.91%   -0.10%     
==========================================
  Files          35       36       +1     
  Lines        2671     2672       +1     
==========================================
- Hits         1790     1788       -2     
- Misses        881      884       +3     
Impacted Files Coverage Δ
derive/src/derive_enum.rs 0.00% <0.00%> (ø)
derive/src/derive_struct.rs 0.00% <0.00%> (ø)
src/features/serde/mod.rs 0.00% <0.00%> (ø)
src/de/impls.rs 79.22% <96.49%> (ø)
src/de/impl_tuples.rs 100.00% <100.00%> (ø)
src/de/mod.rs 65.51% <100.00%> (-13.80%) ⬇️
src/features/atomic.rs 100.00% <100.00%> (ø)
src/features/impl_alloc.rs 98.24% <100.00%> (ø)
src/features/impl_std.rs 77.55% <100.00%> (ø)
tests/alloc.rs 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d38649...c4cb2d7. Read the comment docs.

@VictorKoenders VictorKoenders merged commit 8c3dd01 into trunk Jan 11, 2022
@VictorKoenders VictorKoenders deleted the mut_ref_decode branch January 11, 2022 19:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

recursive struct gives: overflow evaluating the requirement SliceReader: Sized

2 participants