This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #443 +/- ##
==========================================
+ Coverage 63.12% 66.97% +3.85%
==========================================
Files 46 35 -11
Lines 3479 2604 -875
==========================================
- Hits 2196 1744 -452
+ Misses 1283 860 -423
Continue to review full report at Codecov.
|
a836a18 to
e4f2511
Compare
fd681b3 to
268a796
Compare
ghost
reviewed
Dec 11, 2021
ghost
approved these changes
Dec 11, 2021
7980042 to
038cdf7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extracts the derive framework from
bincode-deriveinto its own crate. This crate is https://docs.rs/virtue.Additionally fixes some minor issues
src/impl_core.rsnow has some clippy warnings. Because this code is copied fromcoreI've just added a#![allow(clippy::needless_borrow)]at the topcore::mem::replace(&mut self.slice, &mut [])withcore::mem::take(&mut self.slice), so I've implemented that#![crate_type = "dylib"]is now deprecated, so I've removed it