Skip to content
This repository was archived by the owner on Aug 15, 2025. It is now read-only.

Allow serde types to be Decode/Encoded#434

Merged
VictorKoenders merged 8 commits intotrunkfrom
feature/serde_attribute
Nov 9, 2021
Merged

Allow serde types to be Decode/Encoded#434
VictorKoenders merged 8 commits intotrunkfrom
feature/serde_attribute

Conversation

@VictorKoenders
Copy link
Contributor

@VictorKoenders VictorKoenders commented Nov 8, 2021 •
edited
Loading

Adds an attribute that users can add to struct fields

#[derive(bincode::Encode, bincode::Decode)]
struct Foo {
    #[bincode(with_serde)]
    serde: SerdeType
}

Also adds a struct that will wrap any serde type and implements Decode and Encode on it

Closes #433

ghost
ghost reviewed Nov 8, 2021
View reviewed changes
@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2021 •
edited
Loading

Codecov Report

Merging #434 (b676dc5) into trunk (a2e7e0e) will decrease coverage by 1.41%.
The diff coverage is 9.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk     #434      +/-   ##
==========================================
- Coverage   62.97%   61.56%   -1.42%     
==========================================
  Files          46       46              
  Lines        3236     3317      +81     
==========================================
+ Hits         2038     2042       +4     
- Misses       1198     1275      +77
Impacted Files Coverage Δ
derive/src/derive_enum.rs 0.00% <0.00%> (ø)
derive/src/derive_struct.rs 0.00% <0.00%> (ø)
derive/src/lib.rs 5.33% <0.00%> (ø)
derive/src/parse/mod.rs 90.74% <ø> (ø)
src/features/serde/de_borrowed.rs 0.00% <ø> (ø)
src/features/serde/de_owned.rs 0.00% <ø> (ø)
src/features/serde/mod.rs 0.00% <0.00%> (ø)
src/features/serde/ser.rs 0.00% <ø> (ø)
src/lib.rs 100.00% <ø> (ø)
derive/src/parse/body.rs 64.63% <11.11%> (-3.61%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2e7e0e...b676dc5. Read the comment docs.

@VictorKoenders VictorKoenders changed the title [WIP] Allow serde types to be Decode/Encoded Allow serde types to be Decode/Encoded Nov 9, 2021
@VictorKoenders VictorKoenders merged commit cb16c7f into trunk Nov 9, 2021
@VictorKoenders VictorKoenders deleted the feature/serde_attribute branch November 9, 2021 09:08
@kwonoj kwonoj mentioned this pull request Jan 1, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bincode-2 enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Figure out bincode Decode/Encode interop with serde

2 participants

@VictorKoenders @codecov-commenter