This repository was archived by the owner on Aug 15, 2025. It is now read-only.
split off BorrowDecode from Decode in bincode_derive#432
Merged
VictorKoenders merged 7 commits intotrunkfrom Nov 7, 2021
Merged
split off BorrowDecode from Decode in bincode_derive#432VictorKoenders merged 7 commits intotrunkfrom
VictorKoenders merged 7 commits intotrunkfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #432 +/- ##
==========================================
- Coverage 71.04% 70.55% -0.49%
==========================================
Files 41 42 +1
Lines 2811 2839 +28
==========================================
+ Hits 1997 2003 +6
- Misses 814 836 +22
Continue to review full report at Codecov.
|
…DO for cow implementation specialization
Contributor
Author
|
I've taken the liberty to also re-export the |
ghost
reviewed
Nov 7, 2021
ghost
approved these changes
Nov 7, 2021
14b6b89 to
b196fde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've discussed splitting off
DecodefromBorrowDecodederive macro before. This PR actualizes that.This should offer people a solution to issues where the type implements
BorrowDecodewhile people are explicitly requestingDecode. It does not fix the issue aroundCow<T>always needingDecode, we can't fix that until specialization implementation.