This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Generate qualified Result type in derive#430
Merged
VictorKoenders merged 1 commit intobincode-org:trunkfrom Nov 5, 2021
Merged
Generate qualified Result type in derive#430VictorKoenders merged 1 commit intobincode-org:trunkfrom
VictorKoenders merged 1 commit intobincode-org:trunkfrom
Conversation
VictorKoenders
approved these changes
Nov 5, 2021
Contributor
|
Thanks! Just out of sheer interest, how easy did you find it to go through the |
Contributor
Author
|
It was pretty easy to find, but honestly I didn't even have to go through the code, because a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents problems with generated code when there's an alias for a crate-specific
Resulttype, i.e.type Result<T> = std::result::Result<T, MyError>.