This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Merged
Conversation
… for all basic integer types
… feature combinations
src/de/read.rs
Outdated
|
|
||
| #[inline(always)] | ||
| fn get_byte_slice(&mut self, length: usize) -> Result<&'storage [u8]> { | ||
| fn get_byte_slice(&mut self, length: usize) -> Result<&'storage [u8], DecodeError> { |
Contributor
There was a problem hiding this comment.
This function is only used for BorrowReader::take_bytes and nowhere else, what was the reason we split this again?
Author
There was a problem hiding this comment.
I'm not sure, but it might be needed for the peek_read optimization that got added in trunk. I'll evaluate.
…/src/derive_* instead
…d the [u8; N] implementations to [T; N]
…nk in documentation.
a95df79 to
eb8625d
Compare
… _with_config functions
VictorKoenders
approved these changes
Oct 24, 2021
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.