This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #408 +/- ##
==========================================
- Coverage 63.88% 63.41% -0.48%
==========================================
Files 10 10
Lines 850 850
==========================================
- Hits 543 539 -4
- Misses 307 311 +4
Continue to review full report at Codecov.
|
VictorKoenders
approved these changes
Oct 7, 2021
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI was currently broken for two reasons
trunkwas not compliant with the 1.41 MSRV checkclippyhad new warningsSince bincode 2.0 is not even in alpha yet MSRV should not be locked in place. This PR removes the MSRV checks for now. Additionally the few clippy warnings have been resolved.